[FEATURE] Allow more flexible node ids - #362
Merged
Merged
Conversation
micw
force-pushed
the
feature/generic-node-ids
branch
from
May 7, 2026 05:50
525b1a0 to
3dd0112
Compare
micw
changed the title
maurerle
approved these changes
May 9, 2026
maurerle
left a comment
maurerle
left a comment
Member
There was a problem hiding this comment.
Looks good to me as a second commit.
I really like adding some tests to meshviewer!
Member
|
please rebase this. Is there anything still WIP? |
micw
force-pushed
the
feature/generic-node-ids
branch
from
May 10, 2026 14:20
3dd0112 to
d718e81
Compare
micw
changed the title
Contributor
Author
No, only the previous PR which added the demo data (which was extended in this commit) |
Member
|
There are still conflicts. Please have a look |
…nit-Tests Signed-off-by: Michael Wyraz <michael@wyraz.de>
micw
force-pushed
the
feature/generic-node-ids
branch
from
May 11, 2026 04:28
d718e81 to
95bbdc3
Compare
Contributor
Author
"Still" == "Again" ;-) Since I'm adding a bunch of test dependencies, it affects package.json + package.lock, so everytime this is changed upstream there's a new conflict. It's rebased and pushed now. |
MyIgel
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #361, rebase and merge afterwards!
Description
Allow "generic" node ids (alphanumeric + dot).
Motivation and Context
Node IDs are restricted to a fixed length hex string (mac address). This is not compatible with all communities. E.g. Dresden and Leipzig use numeric IDs.
How Has This Been Tested?
Unit tests + Firefox
Screenshots/links:
Checklist: